-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/cloud/gcp/compute: Add SEV_SNP_CAPABLE Guest OS Feature #3579
Conversation
Hi @travier. Thanks a lot for the PR. Do you know if all RHEL-9 versions support SNP feature or if it is available only since some specific minor version of RHEL-9? |
I rebased the PR using web UI |
Unfortunately I don't know. I've asked that to the folks that should know 🙂. |
From another chat, this is RHEL 9.2 and later only (potentially 9.1 but with lesser support): https://bugzilla.redhat.com/show_bug.cgi?id=2081424 |
I added a compatibility case for RHEL-9.0, which does not support SEV-SNP and rebased the PR on top of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The SEV-SNP support was added since RHEL-9.1, so we need to keep the original Guest OS Feature set when importing RHEL-9.0 images to GCP. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
30c82b6
to
729242a
Compare
The installer test on RHEL 8.9 has been causing issues all around lately. I did a rebase to help it along. |
No failed test related to this change. |
See: coreos/coreos-assembler#3547
See: https://cloud.google.com/blog/products/identity-security/rsa-snp-vm-more-confidential
See: https://issues.redhat.com/browse/COS-2343
This pull request includes: