Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/cases/ubi-wsl: test rhel9 ga (HMS-4207) #4165

Merged
merged 1 commit into from
May 29, 2024
Merged

test/cases/ubi-wsl: test rhel9 ga (HMS-4207) #4165

merged 1 commit into from
May 29, 2024

Conversation

croissanne
Copy link
Member

@croissanne croissanne commented May 27, 2024 •
edited
Loading

I updated wsl in the snapshot & switched to an absolute path to wsl. Apparently there are multiple wsl executables, some of which cannot be accessed in the ssh session, and some of which can.

@croissanne croissanne changed the title test/cases/ubi-wsl: test rhel9 ga test/cases/ubi-wsl: test rhel9 ga (HMS-4207) May 27, 2024
@croissanne
Copy link
Member Author

I updated the PR descr + title, but the best-practices wf still fails, opened osbuild/pr-best-practices#3.

kingsleyzissou
kingsleyzissou reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@kingsleyzissou kingsleyzissou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me but there are loads of failed tests. I can't really tell if they're related or not

@croissanne
Copy link
Member Author

Looks okay to me but there are loads of failed tests. I can't really tell if they're related or not

Well the schutzbot nightly failures are 9.4 nightlies, which are no longer relevant since it's ga. And the edge cases I don't know, it's definitely not related but idk why they're failing, @henrywang maybe has some insights.

@henrywang
Copy link
Member

Looks okay to me but there are loads of failed tests. I can't really tell if they're related or not

Well the schutzbot nightly failures are 9.4 nightlies, which are no longer relevant since it's ga. And the edge cases I don't know, it's definitely not related but idk why they're failing, @henrywang maybe has some insights.

Right, failure is not caused by this PR. Failures have been fixed by PR #4148 and #4121. Feel free to skip the Edge test failure.

@croissanne croissanne merged commit 5d1094a into osbuild:main May 29, 2024
44 of 63 checks passed
@croissanne croissanne deleted the rhel9-ga-wsl-test branch May 29, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingsleyzissou kingsleyzissou kingsleyzissou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@croissanne @henrywang @kingsleyzissou