cmd/osbuild-worker-executor: add oaas as worker executor #4189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit imports the repository https://github.com/mvo5/oaas without keeping the history. The history is largely unimportant and can be looked up in https://github.com/mvo5/oaas/commits/main if needed.
Update the imports/names to match the new name "osbuild-worker-executor".
This is needed by the new `osbuild-worker-executor`.
Add the osbuild-worker-executor to the build system and add it to the spec file.
The osbuild-composer linting found a bunch of issues that this commit fixes.
mvo5
force-pushed
the
add-oaas-as-worker-executor
branch
from
3f73300
to
50b8950
Compare
Note that gosec IMHO is a bit silly here, the heuristics used are note very good, i.e. the code is already validating the external inputs and it's not clear to me that "filepath.Clean()" will help but it seems to supress the error. I hope gosec provides value in other places, here it seems to be adding work :/ I also excluded "gosec" from any _test.go files, I do not see why we should gosec tests?
mvo5
force-pushed
the
add-oaas-as-worker-executor
branch
from
50b8950
to
aca1bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a split out of #4184
It adds the new
osbuild-worker-executorwithout actually using it (yet). This way we can retire the old https://github.com/mvo5/oaas repo and work in the osbuild-composer repo together