logrus: add deployment channel as field to the logs #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably it would also work if we remove the default |
|
Hmm - if this works - I should probably move this to the |
thozza
approved these changes
Aug 2, 2024
Would probably make sense, yes. |
|
@croissanne any concerns merging it? |
croissanne
approved these changes
Aug 2, 2024
schuellerf
force-pushed
the
add-deployment-channel-to-logs
branch
from
484b3df
to
145c9f1
Compare
croissanne
approved these changes
Aug 6, 2024
schuellerf
added a commit
to schuellerf/osbuild-composer
that referenced
this pull request
Aug 12, 2024
schuellerf
added a commit
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I saw in the openshift deployment, the parameter
"CHANNEL"is already set implicitly by the environment (…/environments/stage.ymlor…/environments/production.yml)If something like this worked, this would be awesome for filtering logs