-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logrus: add deployment channel as field to the logs #4285
logrus: add deployment channel as field to the logs #4285
Conversation
probably it would also work if we remove the default |
Hmm - if this works - I should probably move this to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The change looks good AFAICT and it could really make the logs easier to filter.
Would probably make sense, yes. |
@croissanne any concerns merging it? |
484b3df
to
145c9f1
Compare
As far as I saw in the openshift deployment, the parameter
"CHANNEL"
is already set implicitly by the environment (…/environments/stage.yml
or…/environments/production.yml
)If something like this worked, this would be awesome for filtering logs