splunk_logger: move environment hook to splunk_logger pt1 #4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
schuellerf
changed the title
schuellerf
changed the title
this has to be in two steps: - duplicate to splunk_logger first - change and use the reference from within go.mod and the main code
schuellerf
force-pushed
the
move-environment-hook-to-pkg
branch
from
434eea3
to
076a570
Compare
croissanne
approved these changes
Aug 13, 2024
This was referenced Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this has to be in two steps:
environment_hooktosplunk_loggerfirstgo.modand the main codeso this PR just duplicates the code to
pkg/splunk_loggerto be able to reference it from there after being onmain(from composer as well as image-builder later on)or can this be done in one go? (...in one "go" 😁 🙄 )