Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day 2 documentation #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Day 2 documentation #5

wants to merge 4 commits into from

Conversation

ojasva
Copy link
Contributor

@ojasva ojasva commented Nov 17, 2021

By shaket

Copy link
Member

@SVijayB SVijayB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move webdev-day2.md which is at the root of the directory to fromScratch/WebDev-Bootcamp and rename file to match the current format.
Or add contents of the current markdown file to the existing fromScratch/WebDev-Bootcamp/WebDev-Bootcamp.md file by adding a new header with the title Day 2.

PR will be merged after the requested changes are made.

webdev-day2.md Outdated
The main idea behind the flex layout is to give the container the ability to alter its items’ width/height (and order) to best fill the available space (mostly to accommodate to all kind of display devices and screen sizes). A flex container expands items to fill available free space or shrinks them to prevent overflow.

<details>
<summary>Basics and terminology</summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the idea of adding

is neat, it breaks inner alignment. Resorting to using a H3 (###) should be enough.

webdev-day2.md Outdated
<br>
<br>

[In depth alignments guide](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Flexible_Box_Layout/Aligning_Items_in_a_Flex_Container)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a final header - Links and add all links under that. Follow below structure:

Links

In depth alignments guide - Link
Lorem Ipsum - Link

webdev-day2.md Outdated

+
</details>
<br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use markdown syntax. Switch from <br> to \.

@SVijayB SVijayB added the documentation Improvements or additions to documentation label Nov 28, 2021
@ojasva
Copy link
Contributor Author

ojasva commented Nov 28, 2021

@SVijayB please check the changes.

@SVijayB
Copy link
Member

SVijayB commented Nov 28, 2021

@ojasva changes requested from the initial review is yet to do be done.

  • Removing summary tags and switching to headers.
  • Changing <br> tags \
  • Clustering links to gether and following format provided.

@SVijayB
Copy link
Member

SVijayB commented Dec 5, 2021

@ojasva status on this?

@ojasva
Copy link
Contributor Author

ojasva commented Dec 6, 2021

@ojasva status on this?

on it sir, a bit occupied with labs and college environment for the first time, so pardon for delays please

@SVijayB
Copy link
Member

SVijayB commented Dec 6, 2021

It's cool, no issues. Take your time xD

@osc-vitap osc-vitap deleted a comment from ojasva Jan 15, 2022
@SVijayB
Copy link
Member

SVijayB commented Jan 15, 2022

@ojasva any updates on this yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants