Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the regex of template version to prevent invalid version format #1594

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Ma1h01
Copy link
Collaborator

@Ma1h01 Ma1h01 commented Jun 20, 2024

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Resolved #1586
Correct the regex of the template version to prevent an invalid version format

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

…format

Signed-off-by: Ma1h01 <yihaomai@gmail.com>
@Ma1h01 Ma1h01 requested a review from AleJo2995 June 20, 2024 14:07
Copy link
Collaborator

@AleJo2995 AleJo2995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleJo2995
Copy link
Collaborator

@Ma1h01 feel free to squash and merge when you decide. Thanks

@Ma1h01 Ma1h01 merged commit 031850f into develop Jun 20, 2024
15 checks passed
@Ma1h01 Ma1h01 deleted the fix/regex-in-template-version-check branch June 20, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trestle author -tv flag doesn't enforce the version format (e.g. 0.0.1) correctly
2 participants