Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lgoettgens committed Jun 29, 2023
1 parent 8504e0d commit 39df429
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions src/Rings/orderings.jl
Original file line number Diff line number Diff line change
Expand Up @@ -169,16 +169,12 @@ end
"""
Orderings actually applied to polynomial rings (as opposed to variable indices)
"""
@attributes mutable struct MonomialOrdering{S}
mutable struct MonomialOrdering{S}
R::S
o::AbsGenOrdering
is_total::Bool
is_total_is_known::Bool

# default constructor for @attributes
function MonomialOrdering{S}(R::S, o::AbsGenOrdering, is_total::Bool, is_total_is_known::Bool) where S
return new{S}(R, o, is_total, is_total_is_known)
end
canonical_matrix::ZZMatrix
end

function MonomialOrdering(R::S, o::AbsGenOrdering) where S
Expand Down Expand Up @@ -1317,8 +1313,11 @@ julia> canonical_matrix(o2)
[0 -1 0]
```
"""
@attr ZZMatrix function canonical_matrix(M::MonomialOrdering)
return canonical_matrix(nvars(base_ring(M)), M.o)
function canonical_matrix(M::MonomialOrdering)
if !isdefined(M, :canonical_matrix)
M.canonical_matrix = canonical_matrix(nvars(base_ring(M)), M.o)
end
return M.canonical_matrix
end

import Base.==
Expand Down

0 comments on commit 39df429

Please sign in to comment.