Rename is_*_form to is_* (#2558)

docs/src/Groups/matgroup.md

@@ -33,10 +33,10 @@ is_unipotent(x::MatrixGroupElem{T}) where T <: FinFieldElem
 
 ```@docs
 SesquilinearForm{T<:RingElem}
-is_alternating_form(f::SesquilinearForm)
-is_hermitian_form(f::SesquilinearForm)
-is_quadratic_form(f::SesquilinearForm)
-is_symmetric_form(f::SesquilinearForm)
+is_alternating(f::SesquilinearForm)
+is_hermitian(f::SesquilinearForm)
+is_quadratic(f::SesquilinearForm)
+is_symmetric(f::SesquilinearForm)
 alternating_form(B::MatElem{T}) where T <: FieldElem
 symmetric_form(B::MatElem{T}) where T <: FieldElem
 hermitian_form(B::MatElem{T}) where T <: FieldElem

src/Groups/matrices/forms.jl

@@ -61,32 +61,32 @@ SesquilinearForm(f::MPolyRingElem{T},sym) where T = SesquilinearForm{T}(f,sym)
 
 
 """
-    is_alternating_form(f::SesquilinearForm)
+    is_alternating(f::SesquilinearForm)
 
 Return whether the form `f` is an alternating form.
 """
-is_alternating_form(f::SesquilinearForm) = f.descr==:alternating
+is_alternating(f::SesquilinearForm) = f.descr==:alternating
 
 """
-    is_hermitian_form(f::SesquilinearForm)
+    is_hermitian(f::SesquilinearForm)
 
 Return whether the form `f` is a hermitian form.
 """
-is_hermitian_form(f::SesquilinearForm) = f.descr==:hermitian
+is_hermitian(f::SesquilinearForm) = f.descr==:hermitian
 
 """
-    is_quadratic_form(f::SesquilinearForm)
+    is_quadratic(f::SesquilinearForm)
 
 Return whether the form `f` is a quadratic form.
 """
-is_quadratic_form(f::SesquilinearForm) = f.descr==:quadratic
+is_quadratic(f::SesquilinearForm) = f.descr==:quadratic
 
 """
-    is_symmetric_form(f::SesquilinearForm)
+    is_symmetric(f::SesquilinearForm)
 
 Return whether the form `f` is a symmetric form.
 """
-is_symmetric_form(f::SesquilinearForm) = f.descr==:symmetric
+is_symmetric(f::SesquilinearForm) = f.descr==:symmetric
 
 
 ########################################################################

src/aliases.jl

@@ -13,7 +13,6 @@
 #@alias isabsolutely_irreducible is_absolutely_irreducible
 @alias isaffine is_affine
 @alias isalmostsimple is_almostsimple
-@alias isalternating_form is_alternating_form
 @alias isample is_ample
 @alias isbicoset is_bicoset
 @alias isbinomial is_binomial
@@ -38,7 +37,6 @@
 @alias isgenerated_by_standard_unit_vectors is_generated_by_standard_unit_vectors
 @alias isglobal is_global
 @alias isgraded is_graded
-@alias ishermitian_form is_hermitian_form
 @alias isinner_automorphism is_inner_automorphism
 @alias isinvariant is_invariant
 @alias isisomorphic_with_alternating_group is_isomorphic_with_alternating_group
@@ -57,7 +55,6 @@
 @alias ispointed is_pointed
 @alias isprojective is_projective
 @alias ispure is_pure
-@alias isquadratic_form is_quadratic_form
 @alias isquaternion_group is_quaternion_group
 @alias isright is_right
 @alias issemiregular is_semiregular
@@ -68,7 +65,6 @@
 @alias issmooth_curve is_smooth_curve
 @alias issolvable is_solvable
 @alias issupersolvable is_supersolvable
-@alias issymmetric_form is_symmetric_form
 @alias istransitive is_transitive
 @alias isunipotent is_unipotent
 @alias isunital is_unital

src/deprecations.jl

@@ -396,3 +396,13 @@ end
 
 @deprecate is_hermitian_matrix(B::MatElem{T}) where T <: FinFieldElem is_hermitian(B)
 @alias ishermitian_matrix is_hermitian_matrix
+
+@deprecate is_alternating_form(f::SesquilinearForm) is_alternating(f)
+@deprecate is_hermitian_form(f::SesquilinearForm) is_hermitian(f)
+@deprecate is_quadratic_form(f::SesquilinearForm) is_quadratic(f)
+@deprecate is_symmetric_form(f::SesquilinearForm) is_symmetric(f)
+
+@alias isalternating_form is_alternating_form
+@alias ishermitian_form is_hermitian_form
+@alias isquadratic_form is_quadratic_form
+@alias issymmetric_form is_symmetric_form

src/exports.jl

@@ -683,7 +683,7 @@ export is_abelian, has_is_abelian, set_is_abelian
 export is_admissible_ordering
 export is_affine
 export is_almostsimple, has_is_almostsimple, set_is_almostsimple
-export is_alternating_form
+export is_alternating
 export is_ample
 export is_basepoint_free
 export is_basic_serialization_type
@@ -738,7 +738,6 @@ export is_global
 export is_gorenstein
 export is_graded
 export is_groebner_basis
-export is_hermitian_form
 export is_homogeneous
 export is_identity_map
 export is_injective
@@ -789,7 +788,6 @@ export is_projective_space
 export is_pure
 export is_q_cartier
 export is_q_gorenstein
-export is_quadratic_form
 export is_quasisimple, has_is_quasisimple, set_is_quasisimple
 export is_quaternion_group, has_is_quaternion_group, set_is_quaternion_group
 export is_radical
@@ -813,7 +811,6 @@ export is_strongly_connected
 export is_subset
 export is_supersolvable, has_is_supersolvable, set_is_supersolvable
 export is_surjective
-export is_symmetric_form
 export is_ternary
 export is_total
 export is_transitive

test/Groups/forms.jl

@@ -11,10 +11,10 @@
    @test base_ring(B)==F
    @test !is_symmetric(B)
    @test !is_hermitian(B)
-   @test is_alternating_form(f)
-   @test !is_quadratic_form(f)
-   @test !is_symmetric_form(f)
-   @test !is_hermitian_form(f)
+   @test is_alternating(f)
+   @test !is_quadratic(f)
+   @test !is_symmetric(f)
+   @test !is_hermitian(f)
    @test_throws AssertionError f = symmetric_form(B)
    @test_throws AssertionError f = hermitian_form(B)
 
@@ -23,7 +23,7 @@
    f = hermitian_form(B)
    @test f isa SesquilinearForm
    @test gram_matrix(f)==B
-   @test is_hermitian_form(f)
+   @test is_hermitian(f)
    @test f.X isa GAP.GapObj
    @test_throws AssertionError f = symmetric_form(B)
    @test_throws AssertionError f = alternating_form(B)
@@ -35,8 +35,8 @@
    f = symmetric_form(B)
    @test f isa SesquilinearForm
    @test gram_matrix(f)==B
-   @test is_symmetric_form(f)
-   @test !is_hermitian_form(f)
+   @test is_symmetric(f)
+   @test !is_hermitian(f)
    @test_throws AssertionError f = alternating_form(B)
    Qf = corresponding_quadratic_form(f)
    R = polynomial_ring(F,4)[1]
@@ -61,20 +61,20 @@
    R,x = polynomial_ring(F,"x")
    p = x^2*z
    Q = quadratic_form(p)
-   @test is_quadratic_form(Q)
+   @test is_quadratic(Q)
    f = corresponding_bilinear_form(Q)
-   @test is_symmetric_form(f)
+   @test is_symmetric(f)
    @test gram_matrix(f)==matrix(F,1,1,[-z])
 
    T,t = polynomial_ring(GF(2),"t")
    F,z = FiniteField(t^2+t+1,"z")
    R = polynomial_ring(F,4)[1]
    p = R[1]*R[2]+z*R[3]*R[4]
    Q = quadratic_form(p)
-   @test is_quadratic_form(Q)
+   @test is_quadratic(Q)
    @test gram_matrix(Q)==matrix(F,4,4,[0 1 0 0; 0 0 0 0; 0 0 0 z; 0 0 0 0])
    f = corresponding_bilinear_form(Q)
-   @test is_alternating_form(f)
+   @test is_alternating(f)
    @test gram_matrix(f)==matrix(F,4,4,[0 1 0 0; 1 0 0 0; 0 0 0 z; 0 0 z 0])
    @test_throws ArgumentError corresponding_quadratic_form(f)
 
@@ -129,7 +129,7 @@ end
    f = symmetric_form(x+transpose(x))
    @test radical(f)[1]==sub(V,[V[1],V[2]])[1]
    @test f*F(3)==F(3)*f;
-   @test is_symmetric_form(f*F(3))
+   @test is_symmetric(f*F(3))
    @test gram_matrix(f*F(3))==F(3)*(x+transpose(x))
    @test is_degenerate(f)
    x[1,2]=1;