TropicalGeometry: allow point_vector as input for initial

oscar-system · Aug 19, 2024 · 8b022d0 · 8b022d0
1 parent 6b48af3
commit 8b022d0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/TropicalGeometry/initial.jl b/src/TropicalGeometry/initial.jl
@@ -46,7 +46,7 @@ x + y + 1
 
 ```
 """
-function initial(f::MPolyRingElem, nu::TropicalSemiringMap, w::Vector{<:Union{QQFieldElem,ZZRingElem,Rational,Integer}}; perturbation::Union{Nothing,Vector{<:Union{QQFieldElem,ZZRingElem,Rational,Integer}}}=nothing)
+function initial(f::MPolyRingElem, nu::TropicalSemiringMap, w::AbstractVector{<:Union{QQFieldElem,ZZRingElem,Rational,Integer}}; perturbation::Union{Nothing,AbstractVector{<:Union{QQFieldElem,ZZRingElem,Rational,Integer}}}=nothing)
 
     ###
     # Evaluate the tropicalization of f and all its terms at w,
@@ -110,7 +110,7 @@ Ideal generated by
   -2*x^2*y + 3*y^3
 ```
 """
-function initial(I::MPolyIdeal, nu::TropicalSemiringMap, w::Vector{<:Union{QQFieldElem,ZZRingElem,Rational,Integer}}; skip_groebner_basis_computation::Bool=false)
+function initial(I::MPolyIdeal, nu::TropicalSemiringMap, w::AbstractVector{<:Union{QQFieldElem,ZZRingElem,Rational,Integer}}; skip_groebner_basis_computation::Bool=false)
     G = (skip_groebner_basis_computation ? gens(G) : groebner_basis(I,nu,w))
     return ideal(initial.(G,Ref(nu),Ref(w)))
 end
diff --git a/test/TropicalGeometry/initial.jl b/test/TropicalGeometry/initial.jl
@@ -12,7 +12,7 @@
         nuMin = tropical_semiring_map(QQ,2)
         nuMax = tropical_semiring_map(QQ,2,max)
         S,(x,y) = GF(2)["x","y"]
-        @test initial(f,nuMin,w) == x^2+y^2 # padic, min
+        @test initial(f,nuMin,point_vector(w)) == x^2+y^2 # padic, min
         @test initial(f,nuMax,w) == x^2+y^2+x+y # tadic, max
 
         K,t = rational_function_field(GF(2),"t")