Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce lazy computation of glueing domains. #2502

Merged

Conversation

HechtiDerLachs
Copy link
Collaborator

As discussed with @simonbrandhorst .

@simonbrandhorst simonbrandhorst enabled auto-merge (squash) June 30, 2023 10:14
@HechtiDerLachs
Copy link
Collaborator Author

It seems that something with Polymake is breaking the CI here. @benlorenz : Do you have an idea of what's going on here?

There will be more errors due to my code, but this might be something different, so I wanted to ask.

@benlorenz
Copy link
Member

The breakage is "just" julia nightly and everything that depends on libjulia (GAP, CxxWrap, libsingular, libpolymake) fails to precompile due to JuliaLang/julia#49012.

Working on it: JuliaPackaging/Yggdrasil#6962

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #2502 (6f183b9) into master (412927a) will increase coverage by 0.03%.
The diff coverage is 98.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2502      +/-   ##
==========================================
+ Coverage   72.91%   72.94%   +0.03%     
==========================================
  Files         406      406              
  Lines       53904    53962      +58     
==========================================
+ Hits        39306    39365      +59     
+ Misses      14598    14597       -1     
Impacted Files Coverage Δ
experimental/Schemes/LazyGlueing.jl 97.95% <97.36%> (+24.27%) ⬆️
...raicGeometry/Schemes/Covering/Morphisms/Methods.jl 100.00% <100.00%> (ø)
.../AlgebraicGeometry/Schemes/Glueing/Constructors.jl 67.41% <100.00%> (-4.72%) ⬇️

... and 5 files with indirect coverage changes

@simonbrandhorst simonbrandhorst merged commit 4b0f472 into oscar-system:master Jun 30, 2023
12 of 15 checks passed
@HechtiDerLachs HechtiDerLachs deleted the lazy_glueing_domains branch June 30, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants