[FTheoryTools] Support for literature model parameters #2569
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2569 +/- ##
==========================================
- Coverage 71.85% 71.82% -0.04%
==========================================
Files 417 417
Lines 57320 57348 +28
==========================================
+ Hits 41187 41189 +2
- Misses 16133 16159 +26
|
|
Thank you @apturner for adding this functionality! This was the exact thing that I found missing a couple of days back. Nice! However, unless I am mistaken, we do not have an example/test which constructs a literature model with model parameters. Please correct if I am mistaken. If indeed correct, then I would suggest adding one, so that we can rest assured that the model parameters code works as intended. |
|
We do actually have such examples; all 7 of the Lawrie/Schäfer-Nameki models have a parameter, and the |
| ```jldoctest | ||
| julia> m = literature_model(arxiv_id = "1212.2949", equation = "3.2", model_parameters = Dict("k" => 5)) | ||
| Assuming that the first row of the given grading is the grading under Kbar | ||
|
|
||
| Global Tate model over a not fully specified base -- SU(2k+1) Tate model with parameter values (k = 5) based on arXiv paper 1212.2949 Eq. (3.2) | ||
|
|
||
| julia> model_parameters(m) | ||
| Dict{String, Int64} with 1 entry: | ||
| "k" => 5 | ||
| ``` |
There was a problem hiding this comment.
Very good. This here is exactly what I was looking for earlier, but somehow must have overlooked this test. Nice!
Adds support for literature model parameters, as well as associated attributes, properties, and documentation.