Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up PR #2537 #2580

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Conversation

StevellM
Copy link
Member

  • Re-work of the printing for divisors and cycles by taking off the charts details and the expansion of the ideal sheaves
  • New printing for EllipticSurface
  • Fix a typo
  • Put coordinates and homogeneous coordinates in brackets for affine/projective spaces compact printing
  • Put more comments on the function is_prime(D::WeilDivisor)
  • Change the doctests accordingly
  • Allow more name printings if known
  • Fix on the "non-satisfying" printing for SpecOpenRingElem

…harts details and the expansion of the ideal sheaves

- New printing for `EllipticSurface`
- Fix a typo
- Put coordinates and homogeneous coordinates in brackets for affine/projective spaces compact printing
- Put more comments on the function `is_prime(D::WeilDivisor)`
- Change the doctests accordingly
@StevellM
Copy link
Member Author

@simonbrandhorst

@simonbrandhorst
Copy link
Collaborator

Thank you!

@simonbrandhorst simonbrandhorst enabled auto-merge (squash) July 20, 2023 11:01
@simonbrandhorst simonbrandhorst merged commit 2e74e70 into oscar-system:master Jul 20, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants