Reorder input arguments of matrix_group
#2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschmitt
force-pushed
the
js/matrixgroup
branch
2 times, most recently
from
ea5c8f9
to
e358dc8
Compare
joschmitt
force-pushed
the
js/matrixgroup
branch
2 times, most recently
from
6109329
to
f3b742e
Compare
`matrix_group`
joschmitt
force-pushed
the
js/matrixgroup
branch
from
f3b742e
to
ca953f8
Compare
fingolfin
approved these changes
Jul 31, 2023
joschmitt
added a commit
to joschmitt/Oscar.jl
that referenced
this pull request
Aug 14, 2023
joschmitt
added a commit
to joschmitt/Oscar.jl
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2098 .
Reorder the signature of
matrix_groupfrommatrix_group(::Int, ::Ring, ...)tomatrix_group(::Ring, ::Int, ...)to align this with othermatrix*methods.I'm actually not sure what the consensus on this was; for now, I allow both version since we have e.g.
general_linear_group(::Int, ::Ring)after all.I also moved the types for
MatrixGroupandMatrixGroupElemtosrc/Groups/types.jland replaced someMatrixGroupconstructors bymatrix_group, see #1380 . (Unfortunately, one cannot aliasMatrixGrouptomatrix_group, so this constitutes a breaking change.)