polyhedral: more standard constructions

[micjoswig]

Many new constructions of polytopes were added.

TODO:

• add more
• defer long_and_winding (because of coordinate type)
• adjust names, i.e., add "polytope" more often

deferred generalized_permutahedron (because of type conversion issue)

[lgoettgens]

I noticed that parts of the additions are inconsistently formatted. @lkastner could you maybe run the formatter on the large chunks of additions?

[lkastner]

I noticed that parts of the additions are inconsistently formatted. @lkastner could you maybe run the formatter on the large chunks of additions?

Again, this is an Oscar wide issue, so why remark it here if the rest of the code is not up to this standard? Furthermore this issue could be solved by having appropriate checks placed in the testsuite. Additionally we have nothing in the docs on JuliaFormatter, which I assume you meant, so I added a paragraph in the styleguide. Out of curiosity I tried to run JuliaFormatter on the entire codebase and it even throws an error.

I do not think this level of feedback is sustainable. Do you want to remark on these formatting / spacing / whitespace issues on every (many) PR(s) in the future?

[lgoettgens]

I noticed that parts of the additions are inconsistently formatted. @lkastner could you maybe run the formatter on the large chunks of additions?

Again, this is an Oscar wide issue, so why remark it here if the rest of the code is not up to this standard? Furthermore this issue could be solved by having appropriate checks placed in the testsuite. Additionally we have nothing in the docs on JuliaFormatter, which I assume you meant, so I added a paragraph in the styleguide. Out of curiosity I tried to run JuliaFormatter on the entire codebase and it even throws an error.

I do not think this level of feedback is sustainable. Do you want to remark on these formatting / spacing / whitespace issues on every (many) PR(s) in the future?

If I remember correctly, I discussed that with some people a while ago (cannot remember who) and the conclusion was more or less: We do not run the formatter on everything at some point, as that creates conflicts with all open PRs and makes git blame basically unusable. Instead, new additions should follow the formatting styleguide, and whenever you touch large parts of a function you may format that as well.

However, I do not think this is the right place to discuss it. We should move that to a discussion thread, slack, or a Friday meeting (unfortunately I cannot participate this and next week due to travel), to get a broader range of opinions and then write the result down somewhere, e.g. the dev docs.