More hilbert_series #2630
Merged
More hilbert_series #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scar.jl into Hilbert_series_integration
…scar.jl into Hilbert_series_integration
…scar.jl into Hilbert_series_integration
…eaning in the ideal code
…scar.jl into Hilbert_series_integration
…scar.jl into Hilbert_series_integration
…nstead of FreeModElem
HechtiDerLachs
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2630 +/- ##
==========================================
- Coverage 71.93% 71.90% -0.04%
==========================================
Files 434 437 +3
Lines 61250 61905 +655
==========================================
+ Hits 44063 44511 +448
- Misses 17187 17394 +207
|
HechtiDerLachs
added a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Aug 17, 2023
* Preliminary tests for unified hilbert_series * Include tests. * Hooked in Abbott code * Extract my implementation of hilbert series into a separate file. * Add some comments. * New scope for verbosity in hilbert series numerator code * Extensive cleaning; working towards OSCAR coding stds * Fixed minor typos * Minor modification in method selection and cwlean up of docstrings. * Return the denominator for the hilbert series in factorized form. * Adjust tests. * Renaming (to OSCAR conventions); syntactic cleaning * Fixed bug in ideal(0) short-cut * First implementation of hilbert series numerator for modules; more cleaning in the ideal code * Fixed small typo * First step towards unifying hilbert_series interface * Corrected doc; renamed local var * Added kwarg parent; corrected indentation * Get rid of restrictive types. * Clean up the multi_hilbert_series. * Update tests. * Clean up the original hilbert_series. * Add some cleanup. * Update tests. * Added test_throws * Handle R^0 correctly; new UI to allow freemodule as arg * Now allow R/ideal() as input; partial prototype for denom * Commented out short-cut for ideal(0) because it got denom wrong * Renamed HSNum_fudge to HSNum_abbott * First phase of refactoring * Main fn is now called hilbert_series; cannot handle non ZZ^m grading * Tidying & renaming; internal fns now require HSRing arg * Scattered tidying inside multi_hilbert_series * hilbert_series: Now has kwargs backend & parent; not yet working for non-ZZ^m-graded rings * Better comment * Improved example in doc; removed cruft * Removed cruft * Removed cruft * Fixed rank 0 case; added comments * Disabled MPolyBuildCtx in HS_denominator: gives error for univariate poly rings * Syntactic cleaning * Improved comment * Added new test hilbert.jl * Now have hilbert_series and multi_hilbert_series (for modules) * Changed fn prototype for graded_map (line 575): AbstractFreeModElem instead of FreeModElem * Corrected doc string; added new doc string * Corrected doctest * New tests (for hilbert_series) * Use univariate laurent polynomials as default in the module case. * Fix doctests. * Fix doctests once more. --------- Co-authored-by: Matthias Zach <zach@math.uni-hannover.de> Co-authored-by: Matthias Zach <85350711+HechtiDerLachs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary PR to facilitate collaboration.