Modular Gröbner bases #2632
Merged
Modular Gröbner bases #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2632 +/- ##
==========================================
+ Coverage 71.12% 71.15% +0.03%
==========================================
Files 429 429
Lines 60703 60751 +48
==========================================
+ Hits 43175 43230 +55
+ Misses 17528 17521 -7
|
ederc
force-pushed
the
rm/modular-groebner
branch
from
7841e6a
to
e1c292d
Compare
|
the runtime seems to be a 1.9.2 vs 1.9.1 problem. 1.9.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds modular Gröbner basis computations using Singular underneath. Initially implemented by @fieker in
experimental, moved tosrcby @RafaelDavidMohr.Note: This is still probabilistic and misses a certification tests, to be done as next steps.