Non simple fields #2633
Merged
Non simple fields #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by translating to simple ones. Not neccessarily optimal the caching of the simple field (_collaps) should eventually move to Hecke...
|
Maybe we can avoid having yet another name to simplify a number field. Could we maybe use |
|
solves #2435 |
|
I'll change it
…On Mon, 7 Aug 2023, 12:33 Tommy Hofmann, ***@***.***> wrote:
Maybe we can avoid having yet another name to simplify a number field.
Could we maybe use _absolute_simple_field or absolute_simple_field_cached?
Then it is clear what it is doing.
—
Reply to this email directly, view it on GitHub
<#2633 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA36CV7V7AYK37QJ2FDRDWLXUC77TANCNFSM6AAAAAA3GYZ6HE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
... and hope that we'll add caching in Hecke
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2633 +/- ##
==========================================
+ Coverage 72.04% 72.19% +0.15%
==========================================
Files 429 429
Lines 60691 61676 +985
==========================================
+ Hits 43722 44527 +805
- Misses 16969 17149 +180
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.