Resfix #2634
Merged
Resfix #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ederc
reviewed
Aug 7, 2023
src/Modules/UngradedModules.jl
Outdated
| @@ -6386,13 +6384,11 @@ function free_resolution(M::SubquoModule{<:MPolyRingElem}; | |||
| singular_kernel_entry = Singular.Module(base_ring(singular_free_module), | |||
| [singular_free_module(repres(g)) for g in gens(kernel_entry)]...) | |||
|
|
|||
| singular_kernel_entry.isGB = true | |||
| gbpres = Singular.std(singular_kernel_entry) | |||
There was a problem hiding this comment.
Only fres and sres need a precomputed Gröbner basis of the input. Maybe we should not globally do this since other algorithms like mres will be added.
There was a problem hiding this comment.
OK will shift the line for future cases.
hannes14
approved these changes
Aug 8, 2023
This was referenced Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes free resolutions.