QuadFormWithIsom patch 1
#2661
Merged
QuadFormWithIsom patch 1
#2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Re-enable some previously deleted tests; - Extend the primitive extensions methods for general even lattices; - Fix the output of `image_centralizer_in_Oq` to be consistent with its cousin function `image_in_Oq`; - Apply further suggestions of the last PR: namely add the semi-colon for optional arguments, remove the instances of `Hecke.` whenever possible, etc...; - Try to modify some parts of the codes to improve memory allocations. Hopefully this should help to improve testing of the code, outside the compilation issues; - Fix some minors issues found using the package.
thofma
reviewed
Aug 14, 2023
| @@ -461,7 +465,7 @@ function representatives_of_hermitian_type(Lf::ZZLatWithIsom, m::Int = 1) | |||
| ok, rk = divides(rk, euler_phi(n*m)) | |||
| ok || return reps | |||
|
|
|||
| gene = Hecke.HermGenus[] | |||
| gene = HermGenus[] | |||
There was a problem hiding this comment.
HermGenus is not a concrete type if I remember correctly. There should be a hermitian_genus_type(E) or something like that in Hecke.
There was a problem hiding this comment.
Ah yes, indeed, thanks! I forgot about that function..
thofma
approved these changes
Aug 14, 2023
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Aug 17, 2023
justus-springer
pushed a commit
to justus-springer/Oscar.jl
that referenced
this pull request
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch of
QuadFormWithIsom:primitive_extensionsmethods for general even lattices;image_centralizer_in_Oqto be consistent with its cousin functionimage_in_Oq;Hecke.whenever possible, etc...;NB: I forgot to change and create a new branch, so all the old commits appear here... I will delete the current branch after this PR.