Improve documentation for morphisms from rational functions. #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2665 +/- ##
==========================================
- Coverage 71.76% 71.75% -0.01%
==========================================
Files 434 434
Lines 61244 61244
==========================================
- Hits 43950 43944 -6
- Misses 17294 17300 +6
|
Merged
simonbrandhorst
approved these changes
Aug 21, 2023
|
|
||
| ### | ||
| # Find a random open subset `W ⊂ U` to which all the rational functions | ||
| # represented by the elements in `a` can be extended as regular functions. | ||
| function _random_extension(U::AbsSpec, a::Vector{<:FieldElem}) |
There was a problem hiding this comment.
where is the randomization?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @simonbrandhorst and needed for our Oscar book chapter.