Catelnuovo-Mumford regularity #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
reviewed
Aug 12, 2023
src/Modules/UngradedModules.jl
Outdated
| julia> regularity(M) | ||
| 3 | ||
|
|
||
| julia> minimal_betti_table(M); |
There was a problem hiding this comment.
Why would you add the betti table to the doctest, if it doesn't get shown?
There was a problem hiding this comment.
There is a problem with the documenter in printing betti tables. The ; will be removed as soon as this problem is fixed.
src/Rings/mpoly-ideals.jl
Outdated
| julia> regularity(I) | ||
| 6 | ||
|
|
||
| julia> minimal_betti_table(I); |
|
Our decision against submodules in OSCAR requires long names throughout. Please rename regularity to CM_regularity or similar. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2666 +/- ##
==========================================
- Coverage 72.25% 72.19% -0.07%
==========================================
Files 437 437
Lines 61995 62012 +17
==========================================
- Hits 44796 44769 -27
- Misses 17199 17243 +44
|
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Aug 17, 2023
* Catelnuovo-Mumford regularity * React to code review * correcting once more * Reacting to @micjoswig
justus-springer
pushed a commit
to justus-springer/Oscar.jl
that referenced
this pull request
Aug 18, 2023
* Catelnuovo-Mumford regularity * React to code review * correcting once more * Reacting to @micjoswig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.