Hilbert series integration

[JohnAAbbott]

Minor revisions (see also discussion #2674)

[thofma]

The catched error should be checked against the "expected" error and rethrown otherwise.

(The function could also throw, because your input is garbage or the interface changed or ...)

[JohnAAbbott]

Corrected! Thanks for pointing that out. Anyway that code is obsolescent - hopefully is_positively_graded is better written.

[fingolfin]

@HechtiDerLachs (and perhaps also @wdecker ) can you have a look at this? Shall we merge it (perhaps up to the minor tweaks I suggested)?

[fingolfin]

And just to clarify: does this resolve issue #2674 ?

[wdecker]

@fingolfin The crucial part is marked # !!!OBSOLESCENT!!! in Oscar.jl/src/Rings/hilbert.jl. This should be removed and be replaced by the already updated is_positiely_graded function wherever it is called.
@HechtiDerLachs Can you please do this? In particular, you know better than me how this is handled in Oscar.jl/src/Modules/hilbert.jl

[HechtiDerLachs]

I still get the following:

x, y) = graded_polynomial_ring(QQ, ["x", "y"], [1, -1])
(Graded multivariate polynomial ring in 2 variables over QQ, MPolyDecRingElem{QQFieldElem, QQMPolyRingElem}[x, y])

julia> is_positively_graded(R)
true

That's not what's supposed to happen, is it?

Should I really try to fix something already?

[HechtiDerLachs]

Currently tests fail. Probably due to the bug described above.

[wdecker]

I will take a look

[wdecker]

@HechtiDerLachs There is an unmotivated break in John's is_positive_grading_matrix function. Do you agree?

[HechtiDerLachs]

No, I think if the comment prior to that method is correct, then the break is fine. Earlier zero entries are caught by the continue and trailing entries can be skipped.

[wdecker]

Ooops, the whole is_positive_grading_matrix function is scrap. We have to rewrite it in a seperate PR.

[wdecker]

Sorry @JohnAAbbott, the mistake is on my side, your matrix is the transpose of mine. Things will be changed correspondingly.

[HechtiDerLachs]

Looks fine from my side now.