Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize Polyhedral Objects over Oscar fields #3386

Merged
merged 50 commits into from
Feb 22, 2024
Merged

Serialize Polyhedral Objects over Oscar fields #3386

merged 50 commits into from
Feb 22, 2024

Commits on Feb 15, 2024

  1. some progress on serializing dicts

    @antonydellavecchia
    antonydellavecchia committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    bb0f01f View commit details
    Browse the repository at this point in the history

  2. saving

    @antonydellavecchia
    antonydellavecchia committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    b642547 View commit details
    Browse the repository at this point in the history

  3. serialization: add helpers to deconstruct polymake bigobject to dict 

    currently with a few warnings that might be removed later
    @benlorenz
    benlorenz committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    5d079e1 View commit details
    Browse the repository at this point in the history

  4. updates

    @antonydellavecchia
    antonydellavecchia committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    5c1e5e1 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/adv/serialize-dict' into adv/ser… 

    …ialize-dict
    @antonydellavecchia
    antonydellavecchia committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    af30cf3 View commit details
    Browse the repository at this point in the history

  6. starting on load

    @antonydellavecchia
    antonydellavecchia committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    c51105d View commit details
    Browse the repository at this point in the history

  7. fix type string for saving

    @benlorenz
    benlorenz committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    c9a5510 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. adds work around for vector{Int}

    @antonydellavecchia
    antonydellavecchia committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    0415eda View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into adv/serialize-dict

    @benlorenz
    benlorenz committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    e99acb2 View commit details
    Browse the repository at this point in the history

  3. use new qualified bigobject name

    @benlorenz
    benlorenz committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    08cd473 View commit details
    Browse the repository at this point in the history

  4. serialize dicts

    @antonydellavecchia
    antonydellavecchia committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    03ea531 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/adv/serialize-dict' into adv/ser… 

    …ialize-dict
    @antonydellavecchia
    antonydellavecchia committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    9bd5608 View commit details
    Browse the repository at this point in the history

  6. still need to work out loading

    @antonydellavecchia
    antonydellavecchia committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    1753849 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. can load polyhedral object over different fields

    @antonydellavecchia
    antonydellavecchia committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    77687a8 View commit details
    Browse the repository at this point in the history

  2. some updates

    @antonydellavecchia
    antonydellavecchia committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7b4d7e3 View commit details
    Browse the repository at this point in the history

  3. add helpers for conversion from oscar graphs back to polymake

    @benlorenz
    benlorenz committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    12964a4 View commit details
    Browse the repository at this point in the history

  4. tiny improvement

    @antonydellavecchia
    antonydellavecchia committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    52ad96f View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/adv/serialize-dict' into adv/ser… 

    …ialize-dict
    @antonydellavecchia
    antonydellavecchia committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    aea1f6b View commit details
    Browse the repository at this point in the history

  6. fix inner types, store coeff only once

    @benlorenz
    benlorenz committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    79c8a58 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/adv/serialize-dict' into adv/ser… 

    …ialize-dict
    @antonydellavecchia
    antonydellavecchia committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    45e8295 View commit details
    Browse the repository at this point in the history

  8. polymake: improve matrix conversion helpers, allow float in some places

    @benlorenz
    benlorenz committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7cce3ef View commit details
    Browse the repository at this point in the history

  9. adds serialzation for sets

    @antonydellavecchia
    antonydellavecchia committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    8bac3b1 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/adv/serialize-dict' into adv/ser… 

    …ialize-dict
    @antonydellavecchia
    antonydellavecchia committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ba781cb View commit details
    Browse the repository at this point in the history

  11. adds test for dicts

    @antonydellavecchia
    antonydellavecchia committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f30dcdb View commit details
    Browse the repository at this point in the history

  12. adds test for sets

    @antonydellavecchia
    antonydellavecchia committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    22619c9 View commit details
    Browse the repository at this point in the history

  13. replace johnson matrices with Johnson solids

    @antonydellavecchia
    antonydellavecchia committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    21f4fb4 View commit details
    Browse the repository at this point in the history

  14. replace johnson matrices with solids

    @antonydellavecchia
    antonydellavecchia committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    a20a6aa View commit details
    Browse the repository at this point in the history

  15. pretty print the rest of the Johnson Solids

    @antonydellavecchia
    antonydellavecchia committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    04dda3a View commit details
    Browse the repository at this point in the history

  16. pretty print

    @antonydellavecchia
    antonydellavecchia committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    d239187 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. resolve conflicts

    @antonydellavecchia
    antonydellavecchia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    e0e73b8 View commit details
    Browse the repository at this point in the history

  2. padding, + file extension and not pretty printed

    @antonydellavecchia
    antonydellavecchia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f38a7d1 View commit details
    Browse the repository at this point in the history

  3. fixes polyhedral test

    @antonydellavecchia
    antonydellavecchia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    77530cf View commit details
    Browse the repository at this point in the history

  4. update file version tag

    @antonydellavecchia
    antonydellavecchia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c16f6cb View commit details
    Browse the repository at this point in the history

  5. file version tag + add extension for surface files

    @antonydellavecchia
    antonydellavecchia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    3706af8 View commit details
    Browse the repository at this point in the history

  6. fix surface loading

    @antonydellavecchia
    antonydellavecchia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    264deb8 View commit details
    Browse the repository at this point in the history

  7. fix typo

    @antonydellavecchia
    antonydellavecchia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5aa8b7f View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. adds fix for polyhedron of floats and adds test

    @antonydellavecchia
    antonydellavecchia committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    7592d9c View commit details
    Browse the repository at this point in the history

  2. fix typo

    @antonydellavecchia
    antonydellavecchia committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    63701ef View commit details
    Browse the repository at this point in the history

  3. better padding implementation

    @antonydellavecchia
    antonydellavecchia committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    2232068 View commit details
    Browse the repository at this point in the history

  4. adds catch for unsupported loading types

    @antonydellavecchia
    antonydellavecchia committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    c5c9a0a View commit details
    Browse the repository at this point in the history

  5. remove Nothing type for coeff inputs, and fixed vector collect

    @antonydellavecchia
    antonydellavecchia committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    0037062 View commit details
    Browse the repository at this point in the history

  6. adds tests for serializing polyhdral objects over oscar fields

    @antonydellavecchia
    antonydellavecchia committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    8bd1f64 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. fixes to MILP

    @antonydellavecchia
    antonydellavecchia committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    78e99da View commit details
    Browse the repository at this point in the history

  2. MILP: add missing specialization for QQ to avoid saving other fields … 

    …for now
    @benlorenz
    benlorenz committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    198ecc2 View commit details
    Browse the repository at this point in the history

  3. polymake: change warnings to debug when saving unsupported polymake p… 

    …roperties
    @benlorenz
    benlorenz committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    b488c95 View commit details
    Browse the repository at this point in the history

  4. polyhedral: add missing field for loading milp

    @benlorenz
    benlorenz committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    fe211d1 View commit details
    Browse the repository at this point in the history

  5. fix for polyhedron with floats

    @antonydellavecchia
    antonydellavecchia committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    14c88e9 View commit details
    Browse the repository at this point in the history

  6. serialization: fix load distinction between different fields, fix loa… 

    …ding float polytopes
    @benlorenz
    benlorenz committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    945ea75 View commit details
    Browse the repository at this point in the history

  7. Update test/Serialization/PolyhedralGeometry.jl

    @benlorenz
    benlorenz authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    a5d5968 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Lars Kastner <lkastner@users.noreply.github.com>
    @antonydellavecchia @lkastner
    antonydellavecchia and lkastner authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    6933db9 View commit details
    Browse the repository at this point in the history