-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docu invariants tori #3428
Docu invariants tori #3428
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3428 +/- ##
==========================================
+ Coverage 81.90% 81.93% +0.02%
==========================================
Files 561 561
Lines 75131 75173 +42
==========================================
+ Hits 61539 61594 +55
+ Misses 13592 13579 -13
|
This is ready to be merged. |
who can review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
(Unfortunately, I don't have the rights to give an actual approving review.)
over QQ | ||
``` | ||
""" | ||
poly_ring(R::TorGrpInvRing) = R.poly_ring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the invariants of finite groups, we call this polynomial_ring
by now. (This is not really a flaw with this pull request.)
Maybe @joschmitt could have a quick glance? |
Yeah, I don't think we want a |
See #3442. Note that there is still
|
Yes, this should be unexported. |
* Add test example to PR #3412 as requested by @thofma * docu invariants tori * readd algebraic.md * typo * Update docs/doc.main * add one more functions and corrections * correction * correction * addressing review * forgot to add corrected file --------- Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de> (cherry picked from commit 3c5f7fe)
* Add test example to PR oscar-system#3412 as requested by @thofma * docu invariants tori * readd algebraic.md * typo * Update docs/doc.main * add one more functions and corrections * correction * correction * addressing review * forgot to add corrected file --------- Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
- Add QQBar docs to the manual #3423 - do not show the OscarInterface banner #3422 - fix bugs in all_OD_infos #3419 - Ep/ Rename Spec to AffineScheme #3345 #3425 - Remove two mentions of Arb_jll #3431 - Tweak epimorphism_from_free_group #3430 - CI: re-enable nightly #3435 - support gen(G::GAPGroup, 0) #3332 - Align all_*_groups methods some more #3433 - Add all_perfect_groups #3434 - Add all_primitive_groups and all_transitive_groups variants taking a single int or int range #3404 - fix a docstring #3436 - Fixes multivariate division #3396 - Docu invariants tori #3428 - Improve docstrings for is_conjugate/is_conjugate_with_data. #3384 - Fix ambient_module(M::SubquoModule) #3448 - Bugfix for printing of affine schemes #3437 - Bugfix for bugfix for printing of affine schemes #3445 - Update OSCAR banner #3410 - Docu invariants lin. red. groups (Lakshmi Ramesh and Wolfram Decker) #3443 - add od_from_atlas_group, od_from_p_subgroup, and helpers #3444 - Unexport normalise #3453 - support group properties for character tables #3449 - add docstrings for acting_group and action_function #3432 (exports are used in new groups code for the book) - Adjust to renaming of rank(A::FinGenAbGroup) to torsion_free_rank(A::FinGenAbGroup) #3457 - Ensure fp_group(G) transfers group attributes #3464 - Added comment on convention #3467 - Export weierstrass_chart_on_minimal_model and patch transform_to_weierstrass #3458 - Fix a doc signature #3466 - Grading + caching for affine algebra of torus invariants #3469
docu invariants tori
Preview: https://docs.oscar-system.org/previews/PR3428/InvariantTheory/tori/