Disable a test in elliptic surfaces #3698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlorenz
approved these changes
May 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3698 +/- ##
==========================================
- Coverage 83.16% 82.82% -0.35%
==========================================
Files 579 579
Lines 78475 78475
==========================================
- Hits 65265 64995 -270
- Misses 13210 13480 +270 |
|
Please merge. |
#3672 is ready for merging, as soon as the book-test is fixed. @simonbrandhorst 's remark there is non-blocking. |
|
Splitting this off makes it easier to revert and bisect in the future, so I will go on with this. |
joschmitt
added a commit
to joschmitt/Oscar.jl
that referenced
this pull request
May 8, 2024
This reverts commit 85594b1. Commit is made obsolete by PR oscar-system#3672 (85594b1)
simonbrandhorst
pushed a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables the elliptic surface test that sometimes gets stuck, see #3676.
Something similar is done in #3672, but there seems to be some further discussion in that PR, so I would like to get this in now.
CC @benlorenz @HechtiDerLachs