Add Vinberg's algorithm #4023
Closed
Add Vinberg's algorithm #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4023 +/- ##
==========================================
+ Coverage 84.10% 84.66% +0.55%
==========================================
Files 612 613 +1
Lines 83067 83393 +326
==========================================
+ Hits 69865 70606 +741
+ Misses 13202 12787 -415
|
fingolfin
reviewed
Aug 20, 2024
fingolfin
reviewed
Aug 21, 2024
|
Needs sorting and possibly moved to experimental? @simonbrandhorst any idea? It's your baby....(indirectly) |
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Max Horn <max@quendi.de>
Comment on lines
+284
to
+285
| if _crystallographic_condition(Q, v) | ||
| if _check_coorientation(Q, roots, v, v0) |
There was a problem hiding this comment.
This is the hot loop. So these two function will be called many times. Can you make them non-allocating?
|
The math looks good to me. |
Co-authored-by: Simon Brandhorst <brandhorst@math.uni-sb.de>
Co-authored-by: Simon Brandhorst <brandhorst@math.uni-sb.de>
Co-authored-by: Simon Brandhorst <brandhorst@math.uni-sb.de>
Co-authored-by: Simon Brandhorst <brandhorst@math.uni-sb.de>
Co-authored-by: Simon Brandhorst <brandhorst@math.uni-sb.de>
fingolfin
reviewed
Sep 17, 2024
fingolfin
reviewed
Sep 17, 2024
fingolfin
reviewed
Sep 17, 2024
|
I did some local changes but could not figure out how to push them here. Hence I close this and open another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an implementation of Vinberg's algorithm for computing fundamental roots of Lorentzian lattices.
@simonbrandhorst
@StevellM