Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more fixes #4142

Merged
merged 58 commits into from
Oct 2, 2024

Remove duplicated code for compositions.

a03191c
Select commit
Loading
Failed to load commit list.
Merged

Some more fixes #4142

Remove duplicated code for compositions.
a03191c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 2, 2024 in 1s

60.59% of diff hit (target 84.69%)

View this Pull Request on Codecov

60.59% of diff hit (target 84.69%)

Annotations

Check warning on line 481 in experimental/Schemes/src/BlowupMorphism.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/BlowupMorphism.jl#L478-L481

Added lines #L478 - L481 were not covered by tests

Check warning on line 212 in experimental/Schemes/src/BlowupMorphismTypes.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/BlowupMorphismTypes.jl#L211-L212

Added lines #L211 - L212 were not covered by tests

Check warning on line 600 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L599-L600

Added lines #L599 - L600 were not covered by tests

Check warning on line 602 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L602

Added line #L602 was not covered by tests

Check warning on line 608 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L606-L608

Added lines #L606 - L608 were not covered by tests

Check warning on line 611 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L610-L611

Added lines #L610 - L611 were not covered by tests

Check warning on line 619 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L613-L619

Added lines #L613 - L619 were not covered by tests

Check warning on line 621 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L621

Added line #L621 was not covered by tests

Check warning on line 633 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L624-L633

Added lines #L624 - L633 were not covered by tests

Check warning on line 639 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L635-L639

Added lines #L635 - L639 were not covered by tests

Check warning on line 646 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L641-L646

Added lines #L641 - L646 were not covered by tests

Check warning on line 648 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L648

Added line #L648 was not covered by tests

Check warning on line 652 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L651-L652

Added lines #L651 - L652 were not covered by tests

Check warning on line 654 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L654

Added line #L654 was not covered by tests

Check warning on line 658 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L657-L658

Added lines #L657 - L658 were not covered by tests

Check warning on line 662 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L660-L662

Added lines #L660 - L662 were not covered by tests

Check warning on line 664 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L664

Added line #L664 was not covered by tests

Check warning on line 666 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L666

Added line #L666 was not covered by tests

Check warning on line 668 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L668

Added line #L668 was not covered by tests

Check warning on line 670 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L670

Added line #L670 was not covered by tests

Check warning on line 675 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L672-L675

Added lines #L672 - L675 were not covered by tests

Check warning on line 678 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L678

Added line #L678 was not covered by tests

Check warning on line 682 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L681-L682

Added lines #L681 - L682 were not covered by tests

Check warning on line 684 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L684

Added line #L684 was not covered by tests

Check warning on line 687 in experimental/Schemes/src/elliptic_surface.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/elliptic_surface.jl#L686-L687

Added lines #L686 - L687 were not covered by tests