Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename new_ray to exceptional_ray #4433

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

paemurru
Copy link
Contributor

@paemurru paemurru commented Jan 9, 2025

When blowing up along a ray, the ray might coincide with an existing ray, so the variable name new_ray, as well as the corresponding function names, are unsuitable.

Blowing up along a ray, the ray might coincide with an existing ray, so the variable name `new_ray` and corresponding function names are unsuitable.
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.39%. Comparing base (8ab4265) to head (a97a673).
Report is 67 commits behind head on master.

Files with missing lines Patch % Lines
experimental/FTheoryTools/src/auxiliary.jl 50.00% 1 Missing ⚠️
...erimental/Schemes/src/ToricBlowups/constructors.jl 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4433      +/-   ##
==========================================
- Coverage   84.39%   84.39%   -0.01%     
==========================================
  Files         663      663              
  Lines       87954    87939      -15     
==========================================
- Hits        74227    74212      -15     
  Misses      13727    13727              
Files with missing lines Coverage Δ
...xperimental/Schemes/src/ToricBlowups/attributes.jl 93.54% <100.00%> (ø)
experimental/Schemes/src/ToricBlowups/methods.jl 95.83% <100.00%> (ø)
experimental/Schemes/src/ToricBlowups/types.jl 72.72% <100.00%> (+0.41%) ⬆️
...alGeometry/PolyhedralFan/standard_constructions.jl 100.00% <100.00%> (ø)
experimental/FTheoryTools/src/auxiliary.jl 76.00% <50.00%> (ø)
...erimental/Schemes/src/ToricBlowups/constructors.jl 89.83% <92.85%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@HereAround HereAround left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good renaming. Thank you for working on this @paemurru !

@HereAround HereAround merged commit 3505630 into oscar-system:master Jan 9, 2025
28 of 30 checks passed
@paemurru paemurru deleted the ep/rename_exceptional_ray branch January 9, 2025 22:17
@aaruni96 aaruni96 added renaming release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes renaming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants