-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow variables of same positive degree in monomials_of_degree
#4497
Allow variables of same positive degree in monomials_of_degree
#4497
Conversation
Namely, allow variables of the same nonzero degree.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4497 +/- ##
==========================================
- Coverage 84.55% 84.55% -0.01%
==========================================
Files 672 672
Lines 88880 88888 +8
==========================================
+ Hits 75152 75157 +5
- Misses 13728 13731 +3
|
Out of curiosity: Do you have use for these generalizations? I assume that we could support arbitrary positive weights, but that would require a completely different algorithm (I guess lattice point enumeration methods). |
monomials_of_degree
monomials_of_degree
Yes! In projective geometry, graded rings with grading with positive integers is very important. Supporting arbitrary positive weights would be very good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
I realized that we already have |
Namely, allow variables of the same nonzero degree.