Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow variables of same positive degree in monomials_of_degree #4497

Conversation

paemurru
Copy link
Contributor

Namely, allow variables of the same nonzero degree.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.55%. Comparing base (3e86180) to head (bf2272d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4497      +/-   ##
==========================================
- Coverage   84.55%   84.55%   -0.01%     
==========================================
  Files         672      672              
  Lines       88880    88888       +8     
==========================================
+ Hits        75152    75157       +5     
- Misses      13728    13731       +3     
Files with missing lines Coverage Δ
src/InvariantTheory/iterators.jl 90.81% <100.00%> (+0.19%) ⬆️

... and 2 files with indirect coverage changes

@joschmitt
Copy link
Member

Out of curiosity: Do you have use for these generalizations? I assume that we could support arbitrary positive weights, but that would require a completely different algorithm (I guess lattice point enumeration methods).

@joschmitt joschmitt changed the title Further generalize monomials_of_degree Allow variables of same positive degree in monomials_of_degree Jan 24, 2025
@joschmitt joschmitt added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes enhancement New feature or request labels Jan 24, 2025
@paemurru
Copy link
Contributor Author

Yes! In projective geometry, graded rings with grading with positive integers is very important. Supporting arbitrary positive weights would be very good!

Copy link
Member

@joschmitt joschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@joschmitt
Copy link
Member

Yes! In projective geometry, graded rings with grading with positive integers is very important. Supporting arbitrary positive weights would be very good!

I realized that we already have monomial_basis(::MPolyDecRing, ::FinGenAbGroupElem). So this might just need some aligning of interfaces.

@joschmitt joschmitt enabled auto-merge (squash) January 24, 2025 12:33
@joschmitt joschmitt merged commit f329ec4 into oscar-system:master Jan 24, 2025
29 of 31 checks passed
@paemurru paemurru deleted the ep/further_generalize_monomials_of_degree branch January 24, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants