Simplify code for toric blowup along a cone #4505
Merged
+1
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4505 +/- ##
==========================================
- Coverage 84.55% 84.54% -0.01%
==========================================
Files 672 672
Lines 88831 88827 -4
==========================================
- Hits 75109 75103 -6
- Misses 13722 13724 +2
|
HereAround
added
topic: toric varieties
topic: toric schemes
optimization
HereAround
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Thank you for working on this @paemurru . Looks good to me!
aaruni96
added
the
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.