Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix precompilation warnings downstream #466

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Fix precompilation warnings downstream #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
985c968
Fix precompilation warnings downstream
thofma Jan 1, 2024
15a291d
Revert "Fix precompilation warnings downstream"
benlorenz Jan 4, 2024
fd71595
avoid downloads timer hang during precompilation
benlorenz Jan 4, 2024
0568065
bump version
benlorenz Jan 4, 2024
7297009
adjust downloads.jl compat
benlorenz Jan 4, 2024
ac5ddb7
set downloader only when available (julia >= 1.10)
benlorenz Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
name = "Polymake"
uuid = "d720cf60-89b5-51f5-aff5-213f193123e7"
repo = "https://github.com/oscar-system/Polymake.jl.git"
version = "0.11.9"
version = "0.11.10"

[deps]
BinaryWrappers = "f01c122e-0ea1-4f85-ad8f-907073ad7a9f"
CxxWrap = "1f15a43c-97ca-5a2a-ae31-89f07a497df4"
Downloads = "f43a241f-c20a-4ad4-852c-f6b1247861c6"
JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb"
Mongoc = "4fe8b98c-fc19-5c23-8ec2-168ff83495f2"
Expand All @@ -25,10 +26,11 @@ polymake_oscarnumber_jll = "10f31823-b687-53e6-9f29-edb9d4da9f9f"
[compat]
BinaryWrappers = "~0.1.0"
CxxWrap = "~0.14"
Downloads = "^1.4"
JSON = "^0.20, ^0.21"
Libdl = "^1.6"
Mongoc = "~0.6.0, ~0.7.0, ~0.8.0, ~0.9.0"
MozillaCACerts_jll = "2020 - 2023"
MozillaCACerts_jll = "2020 - 2024"
Ninja_jll = "^1.11.1"
Perl_jll = "^5.34.0"
Pkg = "^1.6"
Expand Down
9 changes: 9 additions & 0 deletions src/Polymake.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
union, union!

import Pkg
import Downloads
import JSON

using SparseArrays
Expand Down Expand Up @@ -181,8 +182,16 @@
# to avoid conflicts between symlinks and directories we switch to a new depstree folder name
polymake_deps_tree = @get_scratch!("$(scratch_key)_depstree_v2")

@static if isdefined(Downloads, :default_downloader!)

Check warning on line 185 in src/Polymake.jl

View check run for this annotation

Codecov / codecov/patch

src/Polymake.jl#L185 

Added line #L185 was not covered by tests
# work around long Downloads.jl timer
Downloads.default_downloader!(Downloads.Downloader(grace=0.01))
end
# we run this on every init to make sure all artifacts still exist
prepare_deps_tree(polymake_deps_tree)
@static if isdefined(Downloads, :default_downloader!)

Check warning on line 191 in src/Polymake.jl

View check run for this annotation

Codecov / codecov/patch

src/Polymake.jl#L191 

Added line #L191 was not covered by tests
# restore default
Downloads.default_downloader!()
end

polymake_user_dir = @get_scratch!("$(scratch_key)_userdir")

Expand Down
Loading