Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash functions. #139

Merged
merged 2 commits into from
Sep 24, 2019
Merged

Add hash functions. #139

merged 2 commits into from
Sep 24, 2019

Conversation

wbhart
Copy link
Contributor

@wbhart wbhart commented Sep 18, 2019

Fixes #120

@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #139   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          34     34           
  Lines        2783   2834   +51     
=====================================
- Misses       2783   2834   +51
Impacted Files Coverage Δ
src/Singular.jl 0% <ø> (ø) ⬆️
src/number/n_Zp.jl 0% <0%> (ø) ⬆️
src/number/n_unknown.jl 0% <0%> (ø) ⬆️
src/number/n_Q.jl 0% <0%> (ø) ⬆️
src/number/n_GF.jl 0% <0%> (ø) ⬆️
src/ideal/ideal.jl 0% <0%> (ø) ⬆️
src/module/vector.jl 0% <0%> (ø) ⬆️
src/matrix/matrix.jl 0% <0%> (ø) ⬆️
src/number/n_Z.jl 0% <0%> (ø) ⬆️
src/resolution/resolution.jl 0% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5184de8...af8a0fb. Read the comment docs.

@wbhart
Copy link
Contributor Author

wbhart commented Sep 19, 2019

@hannes14 @raulepure @heiderich Someone needs to review this and/or merge it.

@wbhart
Copy link
Contributor Author

wbhart commented Sep 24, 2019

@hannes14 @raulepure @heiderich

Without this patch, Singular.jl is now broken and fails tests on @rbehrends CI. It would be appreciated if someone could review the patch and merge it.

@thofma
Copy link
Collaborator

thofma commented Sep 24, 2019

Give me push access and I will merge it ;)

@hannes14 hannes14 merged commit 239bc13 into oscar-system:master Sep 24, 2019
fingolfin pushed a commit to fingolfin/Singular.jl that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unique polynomials
3 participants