Improve URL normalization in bin.ts #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation did not handle https URLs. If one cloned a repository via https://github.com/my/project.git the URL in
CHANGELOG.md
still contained the .git suffix. This is only a issue if a newCHANGELOG.md
file is created by--init
, otherwise the correct URL is taken from existing tag / compare entries.Also the remoteUrls protocol does not need to be set by hand, since new URL() seems to parse the correct protocol from the URL.
I tested the implementation with these inputs:
I think it would be a good idea to move
normalizeUrl
into the library code and add some unit tests, but I am not sure if you want this since this is only used inbin.ts