This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct-web init noder; mv noder noder-react-native
…the real source file
修改版的react-web是指修复了什么bug还是提升了什么性能? |
我比较关心就是您这个修改版的react-web会不会一直支持。。。。 |
修改版的主要内容见我向原作者 淘宝前端 的 pull request taofed/react-web#145 ,主要是添加了几个运行 noder-react-native 必须的组件,以及一些 BUG 修复 如果他们接受了这个 PR ,那有 淘宝前端 的支持就问题不大 而我也有兴趣至少支持半年,到时再看是否又有其它东西吸引我 😄 |
ok, 好的 |
@flyskywhy , 感谢 |
注:淘宝前端 已经合并了我写的修改版的 react-web 对应的 pull request 😆 另:上面提到的 react-native-html-render 的 BUG 不知您啥时有空修改一下? |
这个啊,周末吧,现在困了 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用了修改版的 react-web https://github.com/flyskywhy/react-web ,现可在不影响 ios 和 android 客户端的影响下,添加了浏览器端的支持,做到了代码一次编写、到处(ios, android, web)运行。
我只是增加了 react-web 这个特性的支持,后续不会去增加 noder-react-native 本身的功能,如果 @soliury 不介意后续自己去完善的话(比如浏览器端不太可能扫码登录),可以合并本 pull request :P
另外,我看到 react-native-html-render 是您的项目,如果有空的话请将我在 post_npm_install.sh 中描述的两个 BUG (奇怪的是这两个 BUG 会在 web 版上但不会在 android 版上爆发)修复一下并更新到 npm 上,谢谢: