build,refactor(ime,ui,util): eliminate warnings during build

- Suppress unchecked casts - Eliminate implicit casts - Remove redundant parameters
osfans · Jan 9, 2023 · ca0f87b · ca0f87b
1 parent 3002abd
commit ca0f87b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/app/src/main/java/com/osfans/trime/ime/keyboard/KeyboardSwitcher.kt b/app/src/main/java/com/osfans/trime/ime/keyboard/KeyboardSwitcher.kt
@@ -27,6 +27,7 @@ object KeyboardSwitcher {
         newOrReset()
     }
 
+    @Suppress("UNCHECKED_CAST")
     @JvmStatic
     fun newOrReset() {
         Timber.d("Refreshing keyboard padding ...")

diff --git a/app/src/main/java/com/osfans/trime/ui/setup/SetupPage.kt b/app/src/main/java/com/osfans/trime/ui/setup/SetupPage.kt
@@ -28,9 +28,11 @@ enum class SetupPage {
         }
     )
 
-    fun getButtonAction(context: Context) = when (this) {
-        Enable -> InputMethodUtils.showImeEnablerActivity(context)
-        Select -> InputMethodUtils.showImePicker(context)
+    fun getButtonAction(context: Context) {
+        when (this) {
+            Enable -> InputMethodUtils.showImeEnablerActivity(context)
+            Select -> InputMethodUtils.showImePicker()
+        }
     }
 
     fun isDone() = when (this) {

diff --git a/app/src/main/java/com/osfans/trime/util/CollectionUtils.kt b/app/src/main/java/com/osfans/trime/util/CollectionUtils.kt
@@ -4,6 +4,7 @@ object CollectionUtils {
     @JvmStatic
     fun <K, V> getOrDefault(map: Map<K, V>, key: K, defaultValue: V): V = map[key] ?: defaultValue
 
+    @Suppress("UNCHECKED_CAST")
     @JvmStatic
     fun obtainValue(map: Map<String?, Any?>?, vararg: String?): Any? {
         if (map.isNullOrEmpty() || vararg == null) return null

diff --git a/app/src/main/java/com/osfans/trime/util/InputMethodUtils.kt b/app/src/main/java/com/osfans/trime/util/InputMethodUtils.kt
@@ -33,7 +33,7 @@ object InputMethodUtils {
     fun showImeEnablerActivity(context: Context) =
         context.startActivity(Intent(Settings.ACTION_INPUT_METHOD_SETTINGS))
 
-    fun showImePicker(context: Context): Boolean {
+    fun showImePicker(): Boolean {
         inputMethodManager.showInputMethodPicker()
         return true
     }