Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the toolbar of LiquidKeyboard every time LiquidKeyboard is started. #1185

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

goofyz
Copy link
Collaborator

@goofyz goofyz commented Jan 18, 2024

This fixes an unintentional side effect caused by commit db63dab.

refs #1177

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #1177

Feature

Show the toolbar of LiquidKeyboard every time LiquidKeyboard is started.

Code of conduct

Style lint

  • make sytle-lint

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub action ci pass
  4. At least one contributor reviews and votes
  5. Can be merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

This fixes an unintentional side effect caused by commit db63dab.

refs osfans#1177
Copy link
Collaborator

@Bambooin Bambooin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with this patch, I can't reproduce the issue.

@Bambooin Bambooin merged commit 8a4177d into osfans:develop Jan 18, 2024
3 checks passed
@goofyz goofyz deleted the fix-1177 branch January 18, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

液体键盘BUG
2 participants