Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document advertising additional startd attributes (SOFTWARE-5324) #134

Merged

Conversation

matyasselmeci
Copy link
Contributor

This is one of those "if you don't know why you'd want to use it, you probably shouldn't" features but there isn't really a place for reference documentation and I don't want to have it be undocumented, so here it is.

This is one of those "if you don't know why you'd want to use it, you
probably shouldn't" features but there isn't really a place for
reference documentation and I don't want to have it be undocumented,
so here it is.
@brianhlin
Copy link
Contributor

Since @osg-cat has been talking about how he wants to rework this doc, I'd like to leave it up to him to determine whether or not this should go here. I think I'd prefer reference docs to go into the README

@osg-cat
Copy link
Contributor

osg-cat commented Nov 7, 2023

I’m fine adding this for now, so that it doesn’t get lost.

Copy link
Contributor

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Pre-approving

docs/resource-sharing/os-backfill-containers.md Outdated Show resolved Hide resolved
docs/resource-sharing/os-backfill-containers.md Outdated Show resolved Hide resolved
docs/resource-sharing/os-backfill-containers.md Outdated Show resolved Hide resolved
docs/resource-sharing/os-backfill-containers.md Outdated Show resolved Hide resolved
Co-authored-by: Brian Lin <brianhlin@gmail.com>
@matyasselmeci matyasselmeci merged commit 3ea009c into osg-htc:master Nov 7, 2023
1 check passed
@matyasselmeci matyasselmeci deleted the pr/custom-attributes.SOFTWARE-5324 branch November 7, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants