-
-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate WMI Query Handling from Util #728
Conversation
as non-static states to the WmiQueryHandler and introduce new handle*()-methods (#716).
…ct WindowsSoundCardCache and a default, thread-safe WindowsSoundCardDefaultCache (#716).
…ct WindowsUsbDeviceCache and a default, thread-safe WindowsUsbDeviceDefaultCache. Collector logic is moved to the WindowsUsbDeviceCollector (#716).
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
=========================================
Coverage 82.64% 82.64%
Complexity 198 198
=========================================
Files 28 28
Lines 1527 1527
Branches 224 224
=========================================
Hits 1262 1262
Misses 127 127
Partials 138 138 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An initial run-through. Key initial comment is that we should move the instantiation of these new classes out of the top-level SystemInfo
class so we don't have to pass arguments around everywhere.
oshi-core/src/main/java/oshi/hardware/platform/windows/WindowsComputerSystem.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/hardware/platform/windows/WindowsHardwareAbstractionLayer.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/hardware/platform/windows/WindowsSoundCard.java
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/hardware/platform/windows/WindowsSoundCardDefaultCache.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/hardware/platform/windows/WindowsUsbDeviceCollector.java
Outdated
Show resolved
Hide resolved
I went ahead and made most of the changes that I suggested in the code review:
|
No description provided.