Reuse already allocated chars array instead of substring

osiegmar · May 10, 2021 · 90fb46a · 90fb46a
1 parent 53ca94b
commit 90fb46a
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/src/main/java/de/siegmar/logbackgelf/SimpleJsonEncoder.java b/src/main/java/de/siegmar/logbackgelf/SimpleJsonEncoder.java
@@ -109,7 +109,8 @@ private void appendKey(final String key) throws IOException {
     private void escapeString(final String str) throws IOException {
         int currentIndex = 0;
         int lastCopyIndex = 0;
-        for (final char ch : str.toCharArray()) {
+        char[] chars = str.toCharArray();
+        for (final char ch : chars) {
             String escaped = null;
             switch (ch) {
                 case QUOTE:
@@ -132,19 +133,20 @@ private void escapeString(final String str) throws IOException {
                 case '\t':
                     escaped = "\\t";
                     break;
-            }
-            if (ch < ' ') {
-                escaped = escapeCharacter(ch);
+                default:
+                    if (ch < ' ') {
+                        escaped = escapeCharacter(ch);
+                    }
             }
             if (escaped != null) {
-                writer.append(str.substring(lastCopyIndex, currentIndex));
+                writer.write(chars, lastCopyIndex, currentIndex - lastCopyIndex);
                 writer.append(escaped);
                 lastCopyIndex = currentIndex + 1;
             }
             currentIndex++;
         }
         if (lastCopyIndex != currentIndex) {
-            writer.append(str.substring(lastCopyIndex));
+            writer.write(chars, lastCopyIndex, chars.length - lastCopyIndex);
         }
     }