Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy job #40

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Add mypy job #40

merged 1 commit into from
Jul 13, 2023

Conversation

gndrmnn
Copy link
Contributor

@gndrmnn gndrmnn commented Jul 13, 2023

Add mypy playbook, role and job definition for use in other Repos

Mypy is used for automatic Python type checking

@berendt berendt requested a review from osfrickler July 13, 2023 08:51
@gndrmnn gndrmnn marked this pull request as ready for review July 13, 2023 08:51
@gndrmnn
Copy link
Contributor Author

gndrmnn commented Jul 13, 2023

  • TODO: requirements.txt needs to be installed before mypy is run

Mypy is used to automatically check Python type hints.

Signed-off-by: Gondermann <gondermann@b1-systems.de>
@osfrickler
Copy link
Member

What repo do you plan to run this job in? Doing a random test I get:

osism/python-osism$ python3 -m mypy --ignore-missing-imports --install-types --non-interactive .
error: --install-types failed (no mypy cache directory)

@gndrmnn
Copy link
Contributor Author

gndrmnn commented Jul 13, 2023

What repo do you plan to run this job in? Doing a random test I get:

osism/python-osism$ python3 -m mypy --ignore-missing-imports --install-types --non-interactive .
error: --install-types failed (no mypy cache directory)

We are working on the osism-flavor-manager, where the exact call stated in the ansible.command should work already.

The "no mypy cache directory" is probably related to this: python/mypy#10600

Copy link
Member

@osfrickler osfrickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O.k., so let's start with this and adapt as needed

@osfrickler osfrickler merged commit b4c7429 into osism:main Jul 13, 2023
@gndrmnn
Copy link
Contributor Author

gndrmnn commented Jul 13, 2023

Seems to have worked for the flavor manager repo https://github.com/osism/openstack-flavor-manager/pull/37/checks?check_run_id=15009303753 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants