Remove axiom #1109
Open
Remove axiom #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZakarFin
reviewed
Jan 17, 2025
| <dependency> | ||
| <!-- some powermock tests ignores xml packages and tests fails without this --> | ||
| <groupId>org.apache.ws.commons.axiom</groupId> | ||
| <artifactId>axiom-impl</artifactId> |
There was a problem hiding this comment.
If it only affects tests we could use test here?
There was a problem hiding this comment.
Suggested change
| <artifactId>axiom-impl</artifactId> | |
| <artifactId>axiom-impl</artifactId> | |
| <scope>test</scope> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove axiom, fi.nls.oskari.XmlHelper and use org.oskari XmlHelper
Parsing with xpaths don't work with the "future" parser so we can't use it yet=> didn't find problems with xpath but setting sax/features/namespaces to false for nsAware builder caused that ns/uri wasn't parsed and CSWService got null for responseElement.getNamespaceURI
CSWISORecordNamespaceContext.GMDNS.equals(responseElement.getNamespaceURI()=> Invalid response exceptionWithout axiom-impl some control-base tests fails. Removing:
@PowerMockIgnore({"com.sun.org.apache.xalan.*", "com.sun.org.apache.xerces.*", "javax.xml.*", "org.w3c.dom.*", "org.xml.*", "com.sun.org.apache.xml.*"})will fix tests.
For now left axiom-impl in pom.xml and used it in control-base with comments because junit will be udated also and there will be changes for powermock usage. I will remove axiom-impl after junit update.