Improve location error handling

oskarsh · Jan 16, 2024 · 2c854be · 2c854be
1 parent 94bfeb9
commit 2c854be
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/yin_yang/config.py b/yin_yang/config.py
@@ -326,7 +326,7 @@ def defaults(self) -> dict:
             'running': False,
             'dark_mode': False,
             'mode': Modes.MANUAL.value,
-            'coordinates': (0, 0),
+            'coordinates': (0.0, 0.0),
             'update_location': False,
             'update_interval': 60,
             'times': ('07:00', '20:00'),

diff --git a/yin_yang/position.py b/yin_yang/position.py
@@ -51,9 +51,14 @@ def get_qt_position() -> QGeoCoordinate:
 
 def get_ipinfo_position() -> QGeoCoordinate:
     # use the old method as a fallback
-    response = requests.get('https://www.ipinfo.io/loc')
+    try:
+        response = requests.get('https://www.ipinfo.io/loc')
+    except Exception as e:
+        logger.error(e)
+        raise TypeError('Error while sending a request to get location')
+
     if not response.ok:
-        logger.error('Failed to get location from ipinfo.io')
+        raise TypeError('Failed to get location from ipinfo.io')
 
     loc_response = response.text.removesuffix('\n').split(',')
     loc: [float] = [float(coordinate) for coordinate in loc_response]