Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gtk support for Sway and Hyprland #201

Merged
merged 2 commits into from
May 23, 2023
Merged

Conversation

mayapony
Copy link
Contributor

This PR aims to add gtk support for Sway and Hyprland
fix error "Plugin GTK has no support for your desktop environment yet!" under Hyprland
change theme use gsettings, source from https://github.com/swaywm/sway/wiki/GTK-3-settings-on-Wayland#setting-values-in-gsettings

Copy link
Collaborator

@l0drex l0drex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I have added some suggestions, please take a look.

src/config.py Outdated Show resolved Hide resolved
@@ -83,3 +85,14 @@ def __init__(self):
super(_Xfce, self).__init__(['xfconf-query', '-c', 'xsettings', '-p', '/Net/ThemeName', '-s', '{theme}'])
self.theme_light = 'Adwaita'
self.theme_dark = 'Adwaita-dark'

class _Wayland(PluginCommandline):
def __init__(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems the be exactly the same as the Gnome class, so you can just reuse that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a noob, so thank you for your patient advice

@l0drex l0drex changed the base branch from master to beta May 23, 2023 08:46
@l0drex l0drex changed the base branch from beta to master May 23, 2023 08:47
@l0drex l0drex merged commit c0eb2b0 into oskarsh:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants