-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for interactive args #112
Conversation
@xmnlab Please review it. |
@abhijeetSaroha could you rebase your branch on top of the upstream/main please² |
.makim.yaml
Outdated
- task: smoke-tests.dir-absolute-path | ||
- task: smoke-tests.dir-no-path | ||
- task: smoke-tests.dir-relative-path | ||
# - task: smoke-tests.simple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for disabling all thse tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No...I just testing the interactive-args...so I comment down other test cases and forget to un-comment them before committing the changes. Sorry..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have commit the new changes.
@abhijeetSaroha thanks for working on that! the issue you mentioned:
that happens because the default is an empty string. you can test with:
so for now that is not an issue, maybe in the future we could just try to change the way it is displayed. |
I made the required changes. It is working fine with |
thanks for working on that @abhijeetSaroha |
🎉 This PR is included in version 1.17.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
I have implemented a feature to enable interactive arguments using the
input
method instead ofprompt
. The reason for choosinginput
is to avoid the square brackets ([]) displayed during prompts. For example:prompt
:input
:I have tested the feature. Additionally, I have created a test file for this implementation. Please review and test from your side whenever you have time.
Solves #42