feat(ssh): support SSH-based command execution #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmnlab
requested changes
Oct 26, 2024
tests/smoke/.makim-ssh.yaml
Outdated
| tasks: | ||
| start: | ||
| help: Start a service from the dockerfile for ssh tests | ||
| dir: ../../containers |
There was a problem hiding this comment.
Suggested change
| dir: ../../containers | |
| dir: containers |
tests/smoke/.makim-ssh.yaml
Outdated
|
|
||
| build: | ||
| help: Build the dockerfile for ssh tests | ||
| dir: ../../containers |
There was a problem hiding this comment.
Suggested change
| dir: ../../containers | |
| dir: containers |
abhijeetSaroha
changed the title
|
@xmnlab, the implementation functions correctly on Ubuntu; however, it encounters an issue on macOS. The problem arises because Docker is not installed on macOS, resulting in the inability to locate the Docker command. |
|
thanks @abhijeetSaroha ! just skip these tests for macos |
xmnlab
reviewed
Oct 29, 2024
xmnlab
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
lgtm! thanks for working on that @abhijeetSaroha
appreciate that!
|
🎉 This PR is included in version 1.20.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #98