Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssh): support SSH-based command execution #124

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

abhijeetSaroha
Copy link
Collaborator

Solves #98

tasks:
start:
help: Start a service from the dockerfile for ssh tests
dir: ../../containers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dir: ../../containers
dir: containers


build:
help: Build the dockerfile for ssh tests
dir: ../../containers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dir: ../../containers
dir: containers

@abhijeetSaroha abhijeetSaroha changed the title feat: implementation for ssh execution feat(ssh): support SSH-based command execution Oct 27, 2024
@abhijeetSaroha
Copy link
Collaborator Author

@xmnlab, the implementation functions correctly on Ubuntu; however, it encounters an issue on macOS. The problem arises because Docker is not installed on macOS, resulting in the inability to locate the Docker command.

@xmnlab
Copy link
Member

xmnlab commented Oct 27, 2024

thanks @abhijeetSaroha ! just skip these tests for macos

host: localhost
port: 2222
user: testuser
password: testpassword
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhijeetSaroha ,

it would be nice if these values could be rendered from the jinja2 template, so it could accept env variables.

have you tested this use case?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not now, I will test and update you later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants