Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change the default template tag delimiter #97

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented Mar 18, 2024

Pull Request description

This PR implements a new way to use the jinja2 tag delimiter, and instead of {{ any_code }} it will be ${{ any_code }}.
it looks similar to github actions workflow variables, and this also allow us to use prettier auto-format tool to format our makim config file without any weird conflict.

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

@xmnlab xmnlab changed the title feat: Change the default template tag delimitar feat: Change the default template tag delimiter Mar 18, 2024
@xmnlab xmnlab merged commit 7037195 into osl-incubator:main Mar 18, 2024
13 checks passed
@xmnlab xmnlab deleted the improve-template-delimiter branch March 18, 2024 23:15
Copy link

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant