-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(template): Improving the git workflow for the template #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Anavelyz could you update/rebase your branch please?
@Anavelyz thanks for working on that!! about the conda/virtualenv .. that is awesome ... we really to add this support! maybe we could have a quick meeting to discuss a bit more about that, because some backend already implement virtual env under the hood, for example hatch and poetry. I think that if we could keep the ci workflow in just one file, instead of splitting it into different folders it would be better about the git stuff .. I think your approach is not much more complex (many lines) compared to the current approach ... |
😃
Yes, then I do. I should check your changes carefully, in my approach what I try to do is to check whether or not the URLs entered by the users exist.
👍🏾
Don't worry, It's great to see that there is meaningful input 🥳 |
a06ce04
to
fdac66c
Compare
@xmnlab Can you review it? Thank you! |
@Anavelyz , sorry for taking that much time for reviewing this PR, I was on vacation. |
🎉 This PR is included in version 0.6.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Pull Request description
prepare_git
function insrc/scicookie/hooks/post_gen_project.py
.src/scicookie/{{cookiecutter.project_slug}}/.github/workflows/
Solve #38
Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
Reviewer's checklist
main
branch