Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove support for python >3.12,<3.9 #318

Merged
merged 1 commit into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:

tests:
strategy:
fail-fast: false
matrix:
os:
- "ubuntu"
Expand Down Expand Up @@ -148,6 +149,7 @@ jobs:
cancel-in-progress: true

strategy:
fail-fast: false
matrix:
smoke_file:
- automation.sh
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
default_stages:
- commit
- pre-commit

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
Expand Down
4 changes: 2 additions & 2 deletions conda/dev-win.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ dependencies:
- m2-bash
- git
- opensciencelabs::circleci-cli
- python >=3.8.1,<3.12
- python >=3.9,<3.12
- poetry >=1.5
- nodejs
- compilers
- pip
- pip:
- makim==1.15.1
- makim==1.18.1
- paginate
4 changes: 2 additions & 2 deletions conda/dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ dependencies:
- bash
- git
- opensciencelabs::circleci-cli
- python >=3.8.1,<3.12
- python >=3.9,<3.12
- poetry >=1.5
- nodejs
- compilers
- pip
- pip:
- makim==1.15.1
- makim==1.18.1
- paginate==0.5.6
2,554 changes: 1,273 additions & 1,281 deletions poetry.lock

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ include = [
"scicookie" = "scicookie.__main__:app"

[tool.poetry.dependencies]
python = ">=3.8.1,<4"
python = ">=3.9,<4"
cookiecutter = "2.6.0"
colorama = ">=0.4.6"
inquirer = ">=3.1.3"
Expand Down Expand Up @@ -49,6 +49,7 @@ requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

[tool.mypy]
python_version = "3.9"
no_strict_optional = false
exclude = '''(?x)(
src/scicookie/{{cookiecutter.project_slug}}/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ testpaths = [
{%- if cookiecutter.use_black == "yes" %}
[tool.black]
line-length = 79
target-version = ["py38"]
target-version = ["py39"]
force-exclude = '''(?x)(
docs/*
| .*\\.egg-info
Expand Down Expand Up @@ -81,7 +81,7 @@ quote-style = "single"

{%- if cookiecutter.use_mypy == "yes" %}
[tool.mypy]
python_version = "3.8"
python_version = "3.9"
check_untyped_defs = true
strict = true
ignore_missing_imports = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ dev = [
"pydocstyle >= 6.3.0",
{%- endif -%}
{%- if cookiecutter.use_makim == "yes" %}
"makim == 1.15.1",
"makim == 1.18.1",
{%- endif -%}
{%- if cookiecutter.use_vulture == "yes" %}
"vulture >= 2.7",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ classifiers = [
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand All @@ -48,7 +47,7 @@ version = "{{ cookiecutter.project_version }}"
{% else %}
dynamic = ["version"]
{% endif -%}
requires-python = ">=3.8.6,<4"
requires-python = ">=3.9,<4"
dependencies = [
# note: add your dependencies here
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ include = ["{{ package_path }}/py.typed"]
{%- if cookiecutter.documentation_engine == 'quarto' or cookiecutter.sphinx_theme == 'pydata' or cookiecutter.jupyter_book_theme == 'pydata-sphinx-theme' %}
python = ">=3.9,<4"
{% else %}
python = ">=3.8.1,<4"
python = ">=3.9,<4"
{% endif %}
[tool.poetry.group.dev.dependencies]
{% if cookiecutter.use_pytest == "yes" -%}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ channels:
- nodefaults
- conda-forge
dependencies:
- python >=3.8.1,<4
- python >=3.9,<=3.12
- pip
{%- if cookiecutter.build_system == "poetry" %}
- poetry
Expand Down Expand Up @@ -46,4 +46,4 @@ dependencies:
- pip:
# distlib issue
- paginate==0.5.6
{%- endif %}
{%- endif %}
Loading