Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: The navbar can now display the username after logging in #65

Merged
merged 8 commits into from
Oct 28, 2024

Conversation

mkw2107
Copy link
Contributor

@mkw2107 mkw2107 commented Oct 25, 2024

Linked issue/ticket

#40

Description

The navbar can now correctly display the username after login and is properly connected to the database.

Reproduction steps

Log in then check the top right corner to see the username displayed.

Checklist

  • I've followed the Contributing guidelines
  • I've titled my PR according to the Conventional Commits spec
  • I've added tests that fail without this PR but pass with it
  • I've linted, tested, and commented my code
  • I've updated documentation (if appropriate)

@aidanprior aidanprior marked this pull request as draft October 25, 2024 18:13
@mkw2107 mkw2107 marked this pull request as ready for review October 26, 2024 15:30
@aidanprior
Copy link
Collaborator

Is this still accurate Markus, after merging with Nancy's?

The navbar now displays the username after login. Currently, it's a static mock-up as the backend integration isn’t set up yet, but this will be completed in future development stages.

@aidanprior aidanprior marked this pull request as draft October 28, 2024 15:11
@aidanprior aidanprior marked this pull request as ready for review October 28, 2024 15:57
@mkw2107
Copy link
Contributor Author

mkw2107 commented Oct 28, 2024

Many thanks to Aidan for providing crucial assistance and doing a significant amount of work to fix this feature. @aidanprior

Copy link
Contributor

@SamLarivs SamLarivs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!

@SamLarivs SamLarivs merged commit 860d36b into dev Oct 28, 2024
3 checks passed
@aidanprior aidanprior deleted the mkw2107/Navbar-username branch October 28, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants